https://bugzilla.redhat.com/show_bug.cgi?id=979767 --- Comment #5 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to Christopher Meng from comment #3) > Yes. I'll do a full review. > > And please fix the issues above. Fixed. > > Besides why there are > > %{_datadir}/%{name}/translations/qt_it.qm > %{_datadir}/%{name}/translations/qt_nl.qm > > but not in lang file? The don't get picked by find lang. I'm assuming they're something to do with qt5. I've commented in the spec. I hadn't realized that I deleted the spec/srpm. Reuploaded them. Apologies: Spec/srpm: http://ankursinha.fedorapeople.org/kapow/kapow.spec http://ankursinha.fedorapeople.org/kapow/kapow-1.4.4.1-1.fc21.src.rpm Thanks, Warm regards, Ankur -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review