https://bugzilla.redhat.com/show_bug.cgi?id=1020961 Pádraig Brady <p@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p@xxxxxxxxxxxxxx Flags| |fedora-review- --- Comment #4 from Pádraig Brady <p@xxxxxxxxxxxxxx> --- Please use fedora-review flags for feedback This still needs a bit of work. It should have a basic man page. There is a jq.1.default one can use if not building. Building the manpage should be doable though. At a guess you just need to buildRequires rubygem-ronn and rake, and remove these seeminly redundundant deps from the source with a patch: -require 'bonsai' -require 'liquid' -require 'maruku' -require 'json' Also we should make check. Also we don't seem to need python to build. Also we do we really need flex-devel and bison-devel, as opposed to just flex and bison. I did a quick spec (attached) build with the above for f20, but it hit: jq_test.c: In function 'run_jq_tests': jq_test.c:42:10: warning: ignoring return value of 'fgets', declared with attribute warn_unused_result [-Wunused-result] fgets(buf, sizeof(buf), testdata); ^ So that would require patching the source, or removing -Wall from the build args or something. I've left it there for now. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review