https://bugzilla.redhat.com/show_bug.cgi?id=1021160 --- Comment #3 from Ian Weller <ian@xxxxxxxxxxxxx> --- (In reply to Christopher Meng from comment #1) > 1. This package should be named in python-doge and also a parallel > installable python3 subpackage named python3-doge. This isn't a Python library; it's a program that happens to be a Python module. It doesn't make sense to have a subpackage that runs on Python 3. (What would we call the separate Python 3 binary? There are no packaging policies for this.) Examples of packages that provide Python modules but are not called python-$module, because they are standalone programs and not libraries: - anaconda - yum - ansible - gnome-tweak-tool > 2. I can't understand "wow very terminal doge", can you change it to > something better? As Ryan mentioned, this is the upstream summary description, and is directly relevant to the package contents. > 3. BuildRequires: python2-devel > > missing > > BuildRequires: python-setuptools setup.py doesn't use setuptools, so this BuildRequires isn't needed at all. For further evidence, see this Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6080518 > 4. Remove rm -rf %{buildroot} > > 5. %{__python} --> %{__python2} > > %{python_sitelib} --> %{python2_sitelib} 4 and 5 fixed in 0.6.1-2: Spec URL: http://ianweller.fedorapeople.org/SRPMS/doge/0.6.1-2/doge.spec SRPM URL: http://ianweller.fedorapeople.org/SRPMS/doge/0.6.1-2/doge-0.6.1-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review