[Bug 1015701] Review Request: amiri-fonts - Arabic font form amirifont.org

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1015701



--- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Some high-level problems:

1. Guidelines say that fonts must be built from sources, if those are provided.
Here they are provided.

2. -web fonts are the same as in the main package with just some
metainformation removed to save space. I don't think we normally package that.
I think it is normal to just put .woff and other formats in the same -fonts
package.

3. Some of your descriptions in Arabic are not the same as in English, afaict.
This is supposed to be a translation, not a separate text.

4. -common just contains some documentation. It would be better to call it
-docs.
Also, -fonts packages should not depend on it. It is enough to include a copy
of the license file in the -fonts packages.

5. License file is not packaged.

6. There's no need to remove the buildroot.

7. You can drop the empty %files sections and the two "meta" packages. What are
they useful for?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]