https://bugzilla.redhat.com/show_bug.cgi?id=1020456 --- Comment #3 from Arun S A G <sagarun@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= MUST -------- - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines Obviously the dependency needs to packaged and pushed first - Rpmlint: Explicit lib dependency errors. Checking: vagrant-1.3.3-1.1.fc19.noarch.rpm vagrant-1.3.3-1.1.fc19.src.rpm vagrant.noarch: E: explicit-lib-dependency libffi vagrant.noarch: E: explicit-lib-dependency libxml2 vagrant.noarch: E: explicit-lib-dependency libxslt vagrant.noarch: E: explicit-lib-dependency libyaml vagrant.noarch: E: explicit-lib-dependency zlib SHOULD --------- - Please provide short description about your patches in the spec file (Patch0,1,2,3) - %check section can be added to the spec file (optional) https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. [X]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/gems/gems/vagrant-1.3.3/templates, /usr/share/gems/gems/vagrant-1.3.3/keys, /usr/share/gems/gems/vagrant-1.3.3/contrib, /usr/share/gems/gems/vagrant-1.3.3/plugins, /usr/share/gems/gems/vagrant-1.3.3/config [X]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gems/gems/vagrant-1.3.3/plugins, /usr/share/gems/gems/vagrant-1.3.3/config, /usr/share/gems/gems/vagrant-1.3.3/keys, /usr/share/gems/gems/vagrant-1.3.3/contrib, /usr/share/gems/gems/vagrant-1.3.3/templates [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). Note: Please use install -d -m 755 %{buildroot}%{_syscondir}/%{gem_name} instead of install -d -m 755 %{buildroot}/etc/vagrant Same can be done for '%dir %{_sysconfdir}/vagrant' where the name vagrant can be relaced with %{gem_name} [X]: Package is named according to the Package Naming Guidelines. Note: gems should be named as rubygem-%{gem_name}. But vagrant is an application distributed as gem, so it is ok to name it 'vagrant' [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [X]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [+]: Final provides and requires are sane (see attachments). [+]: Package functions as described. [+]: Latest version is packaged. [+]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [+]: Package should compile and build into binary rpms on all supported architectures. scratch build: koji.fedoraproject.org/koji/taskinfo?taskID=6079686 package is a noarch [!]: %check is present and all tests pass. Note: vagrant comes with acceptance and unit tests, we should be atleast running one of them in %check section of spec file https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites [X]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- sudo yum localinstall --nogpgcheck /var/lib/mock/fedora-20-x86_64/result/vagrant-1.3.3-1.1.fc20.noarch.rpm --installroot=/var/lib/mock/fedora-20-x86_64/root/ Error: Package: vagrant-1.3.3-1.1.fc20.noarch (/vagrant-1.3.3-1.1.fc20.noarch) Requires: rubygem(log4r) < 1.2 Error: Package: vagrant-1.3.3-1.1.fc20.noarch (/vagrant-1.3.3-1.1.fc20.noarch) Requires: rubygem(log4r) >= 1.1.9 You could try using --skip-broken to work around the problem You could try running: rpm -Va --nofiles --nodigest Rpmlint ------- Checking: vagrant-1.3.3-1.1.fc19.noarch.rpm vagrant-1.3.3-1.1.fc19.src.rpm vagrant.noarch: E: explicit-lib-dependency libffi vagrant.noarch: E: explicit-lib-dependency libxml2 vagrant.noarch: E: explicit-lib-dependency libxslt vagrant.noarch: E: explicit-lib-dependency libyaml vagrant.noarch: E: explicit-lib-dependency zlib vagrant.noarch: W: spelling-error Summary(en_US) virtualized -> ritualized, visualized, actualized vagrant.noarch: W: spelling-error %description -l en_US virtualized -> ritualized, visualized, actualized vagrant.noarch: W: no-manual-page-for-binary vagrant vagrant.src: W: spelling-error Summary(en_US) virtualized -> ritualized, visualized, actualized vagrant.src: W: spelling-error %description -l en_US virtualized -> ritualized, visualized, actualized vagrant.src:68: W: macro-in-comment %gem_dir 2 packages and 0 specfiles checked; 5 errors, 6 warnings. Requires -------- vagrant (rpmlib, GLIBC filtered): /bin/sh /usr/bin/env /usr/bin/ruby bsdtar curl libffi libxml2 libxslt libyaml openssl ruby(release) ruby(rubygems) rubygem(childprocess) rubygem(erubis) rubygem(i18n) rubygem(log4r) rubygem(net-scp) rubygem(net-ssh) zlib Provides -------- vagrant: rubygem(vagrant) vagrant Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -u https://bugzilla.redhat.com/show_bug.cgi?id=1020456 Buildroot used: fedora-19-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, SugarActivity, Perl, R, PHP, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review