https://bugzilla.redhat.com/show_bug.cgi?id=1020096 Thibault North <thibault.north@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #4 from Thibault North <thibault.north@xxxxxxxxx> --- Thanks for your comments. It's been a long time since the last review request, so I am not that up to date anymore. (In reply to Christopher Meng from comment #1) > 0.I think > > %{?filter_setup: > %filter_provides_in %{python_sitearch}/.*\.so$ > %filter_setup} > > is the old style, please take a look at: > > https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering Is that a proper fix? %global __provides_filter_from ^%{python_sitearch}/.*\.so$ > 1.http://blosc.org/ is its homepage. Fixed. > 2.I would suggest this style: > > License: MIT > URL: https://github.com/FrancescAlted/python-blosc/wiki > Source0: > https://github.com/FrancescAlted/%{name}/archive/Release-%{version}.tar.gz > [...] > BTW can you ask upstream to release in %{name}-%{version} style tarball I chose the pypi source. Unfortunately, there is no docs in that package. Is that still OK ? > BTW can you ask upstream to release in %{name}-%{version} style tarball > name? Or you can use PYPI: Yes, will do. Items 3-7 are also fixed. RPMlint output: rpmlint -v SRPMS/python-blosc-1.1-3.fc19.src.rpm RPMS/x86_64/python-blosc-1.1-3.fc19.x86_64.rpm RPMS/x86_64/python-blosc-debuginfo-1.1-3.fc19.x86_64.rpm SPECS/python-blosc.spec python-blosc.src: I: checking python-blosc.src: I: checking-url https://github.com/FrancescAlted/python-blosc (timeout 10 seconds) python-blosc.src: I: checking-url https://pypi.python.org/packages/source/b/blosc/blosc-1.1.tar.gz (timeout 10 seconds) python-blosc.x86_64: I: checking python-blosc.x86_64: I: checking-url https://github.com/FrancescAlted/python-blosc (timeout 10 seconds) python-blosc.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/blosc/blosc_extension.so blosc_extension.so()(64bit) python-blosc.x86_64: W: no-documentation python-blosc-debuginfo.x86_64: I: checking python-blosc-debuginfo.x86_64: I: checking-url https://github.com/FrancescAlted/python-blosc (timeout 10 seconds) /home/tnorth/rpmbuild/SPECS/python-blosc.spec: I: checking-url https://pypi.python.org/packages/source/b/blosc/blosc-1.1.tar.gz (timeout 10 seconds) 3 packages and 1 specfiles checked; 0 errors, 2 warnings. Updated packages: Spec URL: http://tnorth.fedorapeople.org/rev/python-blosc-1.1-3.fc19.src.rpm SRPM URL: http://tnorth.fedorapeople.org/rev/python-blosc.spec This package depends on blosc, which is also under review, see BZ#1020088 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review