[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1020839



--- Comment #5 from Branislav Blaškovič <bblaskov@xxxxxxxxxx> ---
Thank you for review!

(In reply to Adam Williamson from comment #1)
> First thing I see, no check on the .desktop file is run:

Added.

(In reply to Adam Williamson from comment #2)
> You can drop the Buildroot:

Removed.

(In reply to Adam Williamson from comment #3)
> The provided .src.rpm doesn't seem to have been built from the provided
> .spec

My bad. I've just uploaded the correct one.

(In reply to Adam Williamson from comment #4)
> The source tree clearly specifies the license to be GPLv3+, but the License:
> tag in the spec file states GPLv2+ .

Fixed in spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]