https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #23 from Petr Šabata <psabata@xxxxxxxxxx> --- Ok, I'll repeat some of the things that have already been mentioned but are still in the spec. Just remove the old cruft unless you really want to support this package in EPEL5. That means the BuildRoot tag (line 10), buildroot removal (line 58), and the %clean section (lines 72-73). As this is a noarch package, you don't need line 61. Remove it. I think the lines 64 and 65 could be replaced with simple %{_fixperms} %{buildroot}/*. EE::MM supports DESTDIR and using that is preferred over PERL_INSTALL_ROOT. Now about the dependencies: You have to BuildRequire everything used during the build phase which isn't available in the minimal buildroot (see the Packaging Guidelines for the list). This, of course, includes all the perl modules used by the executed code. When it comes to runtime dependencies, rpmbuild tries to parse the code present in the final RPM and generate the dependency list from that. It's fairly smart but has some known issues. I'd recommend not explicitly Requiring anything, building the package, checking the detected dependencies with 'rpm -qRp package.rpm', and just adding what's missing. In your case, the following BRs are required (Makefile.PL, executed scripts, testsuite, and the tested code): perl perl(Carp) perl(Config) perl(Exporter) perl(ExtUtils::MakeMaker) perl(File::Copy) perl(Getopt::Long) perl(IO::File) perl(IO::Handle) perl(IO::Uncompress::AnyUncompress) perl(Pod::Usage) perl(strict) perl(Test::More) perl(vars) The IO::Compress::, Text::CSV_XS, and HTML::Parser modules don't seem to be required at build time. You should drop those. Both Text::CSV_XS and HTML::Parser will most likely be autodetected by rpmbuild, too. No need to Require them explicitly. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review