[Bug 1019824] Review Request: python-dopy - Python client for the Digital Ocean API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1019824



--- Comment #5 from Björn "besser82" Esser <bjoern.esser@xxxxxxxxx> ---
Unfortunately the hashbang and no-doc issues still persist:

  Rpmlint
  -------
  Checking: python-dopy-0.2.2-2.fc21.noarch.rpm
            python-dopy-0.2.2-2.fc21.src.rpm
  python-dopy.noarch: W: no-documentation
  python-dopy.noarch: E: non-executable-script
    /usr/lib/python2.7/site-packages/dopy/manager.py 0644L /usr/bin/env
  2 packages and 0 specfiles checked; 1 errors, 1 warnings.


  Rpmlint (installed packages)
  ----------------------------
  # rpmlint python-dopy
  python-dopy.noarch: W: no-documentation
  python-dopy.noarch: E: non-executable-script
    /usr/lib/python2.7/site-packages/dopy/manager.py 0644L /usr/bin/env
  1 packages and 0 specfiles checked; 1 errors, 1 warnings.
  # echo 'rpmlint-done:'


You can resolve the hashbang issue by using (your approach somehow doesn't
work):

  for lib in ${modname}/*.py; do
   sed '1{/^#!.*/d}' $lib > $lib.new && \
   touch -r $lib $lib.new &&            \
   mv $lib.new $lib
  done


and the no-doc issue is solved by adding:

  %doc CHANGES LICENSE README.rst


Please make those changes and I can approve.  :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]