Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: gd https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225786 ------- Additional Comments From pertusus@xxxxxxx 2007-03-21 17:34 EST ------- I noticed that the pkgconfig file created in a patch is not right. Something dynamically linking against gd don't certainly need all the link flags, they are needed when doing a static linking, so the following should certainly be like Libs.private: -lXpm -lX11 -ljpeg -lfontconfig -lfreetype -lpng12 -lz -lm Moreover some of those have pkgconfig files, in that case it should even be like Requires.private: x11, xpm, fontconfig, freetype2 and the corresponding flags removed from Libs.private. Not really a blocker, but it is important to have clean .pc files to avoid over-linking, it creates bogus dependencies. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review