https://bugzilla.redhat.com/show_bug.cgi?id=997780 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #5 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- I mostly agree on those python macro... but "we" have approve this ;) >> Notice, I will prefer the python BR in python sub-package. >I don't understand. I just mean to move the "BuildRequires: python3-setuptools python3-devel" in the "%package python" section of the spec. But probably it only make sense to me ;) [x]: Package meets the Packaging Guidelines::Python [x]: Package is named according to the Package Naming Guidelines. [x]: license text(s) [x]: Package consistently uses macros (instead of hard-coded directory names). So: APPROVED -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review