https://bugzilla.redhat.com/show_bug.cgi?id=1018862 --- Comment #3 from Petr Šabata <psabata@xxxxxxxxxx> --- TODO: Remove lines 9, 31, 41, 42, and 45 (Buildroot, %buildroot removal, %clean section, and %defattr) from your SPEC. Those have been obsolete for maybe 10 releases now. TODO: Line 34 (removing of empty directories) is also unnecessary these days. You may drop it too. TODO: Buildrequire perl, called in spec FIX: Buildrequire perl(base), ./lib/File/SearchPath.pm:34 FIX: Buildrequire perl(Carp), ./lib/File/SearchPath.pm:30 TODO: Buildrequire perl(Config), ./lib/File/SearchPath.pm:38, ./t/search.t:5 FIX: Buildrequire perl(Exporter), ./lib/File/SearchPath.pm:34 TODO: Buildrequire perl(strict), ./Build.PL:3, ./lib/File/SearchPath.pm:32 TODO: Buildrequire perl(vars), ./lib/File/SearchPath.pm:35 TODO: Buildrequire perl(warnings), ./Build.PL:4, ./lib/File/SearchPath.pm:31 Please, always go through the source, see what modules are used during the build phase, and BR them. FIX: The license tag is wrong. It should be GPLv2+. See ./lib/File/SearchPath.pm. Fix at least the points marked as FIX before submitting an updated package. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review