https://bugzilla.redhat.com/show_bug.cgi?id=1020096 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |cickumqt@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |cickumqt@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- 0.I think %{?filter_setup: %filter_provides_in %{python_sitearch}/.*\.so$ %filter_setup} is the old style, please take a look at: https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering 1.http://blosc.org/ is its homepage. 2.I would suggest this style: License: MIT URL: https://github.com/FrancescAlted/python-blosc/wiki Source0: https://github.com/FrancescAlted/%{name}/archive/Release-%{version}.tar.gz instead of yours: Source0: https://github.com/FrancescAlted/%{name}/archive/Release-1.1.tar.gz License: MIT URL: https://github.com/FrancescAlted/python-blosc/wiki BTW can you ask upstream to release in %{name}-%{version} style tarball name? Or you can use PYPI: https://pypi.python.org/pypi/blosc to get the tarball. 3.BuildRequires: python-devel blosc-devel Requires: blosc%{?_isa} Should be: BuildRequires: python2-devel python-setuptools blosc-devel No explicit Requires: blosc%{?_isa} unless RPM can't find it. 4.%build python setup.py build --> %{__python2} setup.py build 5.%install rm -rf %{buildroot} python setup.py install -O1 --skip-build --root=%{buildroot} --> %{__python2} setup.py install --prefix=%{_prefix} -O1 --skip-build --root=%{buildroot} 6.I don't agree with shipping VERSION file as %doc, nonsense. 7.%{python_sitearch} --> %{python2_sitearch} ---------- Above comments are generated before fedora-review, please modify and submit a new version, then let's run the review. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review