https://bugzilla.redhat.com/show_bug.cgi?id=1019603 Stephen Gallagher <sgallagh@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |miminar@xxxxxxxxxx Depends On| |1019977 Flags| |needinfo?(miminar@xxxxxxxxx | |m) --- Comment #1 from Stephen Gallagher <sgallagh@xxxxxxxxxx> --- Sorry, took me longer than I expected to get to this today. First comment: it doesn't build in mock/Koji. Among other things, the 'make -C doc html' step fails because it's trying to access the internet to pull down 'docopt' and 'lmi'. The 'docopt' issue is easy: you need to add "BuildRequires: python-docopt". The 'lmi' issue is puzzling. You have BuildRequires: openlmi-tools, which pulls in openlmi-python-base, so the 'lmi' module should be available. After performing a few tests, this looks like a bug in the openlmi-python-base package. It's not registering the 'lmi' module correctly, and thus setuptools doesn't know it is present on the system. I've filed BZ #1019977 to track this. Other comments: I'm not sure that the bash completion script should be %config(noreplace). Under what circumstances do we expect a user to modify this? Nitpicks: These are all noarch packages. The %{?isa} parts aren't required (though it won't hurt). Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1019977 [Bug 1019977] 'lmi' python namespace not properly registered -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review