https://bugzilla.redhat.com/show_bug.cgi?id=1018092 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@xxxxxxxxx --- Comment #2 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. %if 0%{?rhel} == 6 %global pybasever 2.6 %else %global pybasever 2.7 %endif %{!?pybasever: %define pybasever %(%{__python} -c "import sys;print(sys.version[0:3])")} -------- I don't know if you can have a look at rpm -E %python[TAB][TAB]. 2. No need to write : %{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} python2-devel is enough. Also missing python-setuptools. 3. Remove BuildRoot:/rm -fr $RPM_BUILD_ROOT/%clean/%defattr(-,root,root) 4. Shouldn't ship INSTALL file. 5. %{__python}-->%{__python2} %{python_sitelib}-->%{python2_sitelib} 6. Never mark manpages as %doc. 7. %config %{_sysconfdir}/bash_completion.d/ This dir is not owned by this package, please fulfill the path. %config %{_sysconfdir}/bash_completion.d/barman 8. /var --> %_localstatedir 9. Put %pre before %changelog. 10. I never use EOF in RPM, I always use Source1,2... to add them(optional) 11. %setup -n barman-%{version} -q Just %setup -q is OK. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review