https://bugzilla.redhat.com/show_bug.cgi?id=996311 --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL is usable. Ok. Source0 is usable. Ok. Source tar ball is original (SHA-256: a8a1e743b51e7e0b82f4575f4474b2d1e608a85286232f45c42bf4661298dc5b). Ok. Summary verified from lib/CAD/Format/STL.pm. Ok. Description verified from lib/CAD/Format/STL.pm. Ok. License verified from lib/CAD/Format/STL/part.pm and lib/CAD/Format/STL.pm. Ok. No XS code, noarch BuildArch is Ok. TODO: You can replace the `%{__perl}' macro with plain `perl'. TODO: You can remove the deffattr macro completely, because even EPEL-5 has rpm-4.4 where the macro is redundant. TODO: META.yml declares minimal Module::Build version 0.35. Make sure your package builds in EPEL-5 or add this constrain to the corresponding BuildRequire tag. FIX: Remove `v' from `perl(Class::Accessor::Classy) >= v0.1.3' dependency declarations. See what perl-Class-Accessor-Classy package provides and how RPM compares the versions (rpmdev-vercmp v0.1.3 0). TODO: Build-require `perl(bytes)' (lib/CAD/Format/STL.pm:421). version module is optional for tests. Ok. All tests pass. Ok. $ rpmlint perl-CAD-Format-STL.spec ../SRPMS/perl-CAD-Format-STL-0.2.1-3.fc21.src.rpm ../RPMS/noarch/perl-CAD-Format-STL-0.2.1-3.fc21.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-CAD-Format-STL-0.2.1-3.fc21.noarch.rpm drwxr-xr-x 2 root root 0 Oct 16 10:35 /usr/share/doc/perl-CAD-Format-STL -rw-r--r-- 1 root root 267 Apr 5 2010 /usr/share/doc/perl-CAD-Format-STL/Changes -rw-r--r-- 1 root root 286 Apr 5 2010 /usr/share/doc/perl-CAD-Format-STL/README drwxr-xr-x 2 root root 0 Apr 5 2010 /usr/share/doc/perl-CAD-Format-STL/files -rw-r--r-- 1 root root 1417 Apr 5 2010 /usr/share/doc/perl-CAD-Format-STL/files/cube.stl -rw-r--r-- 1 root root 684 Apr 5 2010 /usr/share/doc/perl-CAD-Format-STL/files/cube_binary.stl -rw-r--r-- 1 root root 3342 Oct 16 10:35 /usr/share/man/man3/CAD::Format::STL.3pm.gz -rw-r--r-- 1 root root 2544 Oct 16 10:35 /usr/share/man/man3/CAD::Format::STL::part.3pm.gz drwxr-xr-x 2 root root 0 Oct 16 10:35 /usr/share/perl5/vendor_perl/CAD drwxr-xr-x 2 root root 0 Oct 16 10:35 /usr/share/perl5/vendor_perl/CAD/Format drwxr-xr-x 2 root root 0 Oct 16 10:35 /usr/share/perl5/vendor_perl/CAD/Format/STL -rw-r--r-- 1 root root 11740 Oct 16 10:35 /usr/share/perl5/vendor_perl/CAD/Format/STL.pm -rw-r--r-- 1 root root 2297 Oct 16 10:35 /usr/share/perl5/vendor_perl/CAD/Format/STL/part.pm File location and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-CAD-Format-STL-0.2.1-3.fc21.noarch.rpm | sort -i | uniq -c 1 perl(:MODULE_COMPAT_5.18.1) 1 perl(CAD::Format::STL::part) 1 perl(Carp) 1 perl(Class::Accessor::Classy) 1 perl(Class::Accessor::Classy) >= v0.1.3 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Remove `v' from `perl(Class::Accessor::Classy) >= v0.1.3' dependency declarations. TODO: Filter the under-specified dependency `perl(Class::Accessor::Classy)'. See <https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering>. TODO: Run-require `perl(bytes)' (lib/CAD/Format/STL.pm:421). $ rpm -q --provides -p ../RPMS/noarch/perl-CAD-Format-STL-0.2.1-3.fc21.noarch.rpm | sort -i | uniq -c 1 perl(CAD::Format::STL) = 0.2.1 1 perl(CAD::Format::STL::part) = 0.2.1 1 perl-CAD-Format-STL = 0.2.1-3.fc21 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-CAD-Format-STL-0.2.1-3.fc21.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=6064424). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items, and provide new SPEC file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review