[Bug 1019437] Review Request: eyesight - Hawaii desktop image viewer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1019437



--- Comment #8 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
(In reply to Lubomir Rintel from comment #7)
> (In reply to Antonio Trande from comment #2)
> > Please, use %{name} macro instead of 'eyesight'
> 
> No. That serves no purpose, harms readability and is not required by the
> guidelines.

Indeed, we are not forced to use macros in this case. The main meaning of
consistency is to don't mix shell variables and macros with the same value, for
example $RPM_BUILD_ROOT and %{buildroot}.
In some cases reviewers even are a bit piqued if they read URLs containing
macros, so that they cannot copy and paste them. No problem for me, I run
rpmlint, and I get proper and macro-free links.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]