[Bug 1019437] Review Request: eyesight - Hawaii desktop image viewer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1019437



--- Comment #1 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
# Bundles webp, which is BSD
License:        GPLv2+ and BSD

Libwebp is available separately for Fedora. As a consequence, you remove the
bundled stuff:

# Make sure we don't build bundled stuff
rm -rf src/3rdparty/*

In this case you don't need to recognize the license of libwebp. But wouldn't
it need libwebp-devel as a build requirement?


rm -rf $RPM_BUILD_ROOT
%defattr(-,root,root,-)
This is default for ages and could be safely dropped.


Your package contains translation files. That's why you need to use %find_lang:
http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]