https://bugzilla.redhat.com/show_bug.cgi?id=997780 --- Comment #2 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- Kohi scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6061098 MUST [!]: Package meets the Packaging Guidelines::Python From recent Guidelines change: Package don't contains BR: python2-devel or python3-devel The unversioned macro, %{__python} is deprecated. use {__python2} %{python2_sitelib} macros to be consistent Notice, I will prefer the python BR in python sub-package. [!]: Package is named according to the Package Naming Guidelines. Version 1.0 is not released, so this is a pre-release => Release: 0.1.... [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: If (and only if) the source package includes the text of the license(s) "Common licenses that require including their texts with all derivative works include ASL 2.0..." => COPYING is now present on github SHOULD [!]: Package consistently uses macros (instead of hard-coded directory names). => Could use %{name} in URL, python description, ... COULD [!]: Too large wildcard, because I dislike them ;) %{_libdir}/libgumbo.so.1* %{python_sitelib}/gumbo* -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review