https://bugzilla.redhat.com/show_bug.cgi?id=1018905 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- BuildRoot is not needed. Rerequires: filesystem, coreutils, is also not needed. "The scap-security-guide project provides security configuration guidance in formats of the Security Content Automation Protocol": this sentence is somehow grammatically incorrect. Gzipping of manpages will be done automatically, just copy it into the right place. If the compression method changes, spec will not have to be adjusted. Drop the chcon. Every package I have seen installs man pages without this. Drop %clean. Change .gz to *. in %files, so that it works if the compression changes. Fedora 19 version is hardcoded in various places. Is the package really so version specific, that it must be specific for each version of Fedora? You most certainly want to build this for F20 and rawhide too... Source refers to your personal page. Why can't you use an "real" URL like https://git.fedorahosted.org/cgit/scap-security-guide.git/snapshot/scap-security-guide-d478d863b4166d105dbdd1b577d27edb3f847a86.tar.bz2? This has the advantage that it's easier to see the origin of sources. Please add LICENSE to %files. Directories without known owners: /usr/share/xml/scap/ssg/fedora, /usr/share/xml, /usr/share/xml/scap, /usr/share/xml/scap/ssg/fedora/19, /usr/share/xml/scap/ssg Hm, binary package requires openscap-utils, which in turn requires openscap, totalling 2.8 MB. Why does this requirement exist? -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review