https://bugzilla.redhat.com/show_bug.cgi?id=921134 --- Comment #16 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- May be worth reviewing later commits/fixes to base boost-1.48.0 pkg up to: http://pkgs.fedoraproject.org/cgit/boost.git/commit/?id=dcde8a75575cb4c256ea982593c9710ac16b022c In particular, 1 MUST fix missing -math dep in main metapackage and missing scriptlets fixed in: http://pkgs.fedoraproject.org/cgit/boost.git/commit/?id=8aad81e67cbfd196e040449b0bf2cd854642c447 most of the other commits to 1.48.0 don't look like review blockers to me, but please look it over sooner or later. naming: ok license: ok sources: ok d1e9a7a7f532bb031a3c175d86688d95 boost_1_48_0.tar.bz2 macros: mostly ok (see item 2) 2. SHOULD consider using %{name} and %{?_isa} macros in place of hard-coding boost148 in dependencies. imo, that simplifies things keeps things consistent. for example, replace Requires: boost148-chrono = %{version}-%{release} with Requires: %{name}-chrono%{?_isa} = %{version}-%{release} Fresh scratch epel-6 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6053896 which fails on ppc64 due to: Error: No Package found for mpich2-devel 3. MUST fix build failure on ppc64 somehow, preferably by avoiding ExcludeArch. Possibly omitting mpich bits on ppc64 , something like updating: %ifarch %{arm} %bcond_with mpich2 to %ifarch %{arm} ppc64 %bcond_with mpich2 I think the rest looks pretty good (so far). -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review