[Bug 821455] Review Request: python-trml2pdf12 - Tiny RML2PDF is a tool to easily create PDF documents without programming

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=821455



--- Comment #9 from Jos de Kloe <josdekloe@xxxxxxxxx> ---
Hi Christian,

I'm sorry for the delay. Today I looked  again at your review request, and
still have some problems.

The command:
  fedora-review -b 821455 -m fedora-rawhide-x86_64
now indeed finds the spec file and runs, but it ends with this error:

chmod: cannot access '/builddir/build/BUILDROOT/python-trml2pdf12-1.2-5.fc21.x\
86_64//usr/lib/python2.7/site-packages/TRML2PDF-1.0-py2.7.egg/trml2pdf/t
rml2pdf.py': Not a directory

which is correct, because this is a file not a directory:
/var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILDROOT/python-trml2\
pdf12-1.2-5.fc21.x86_64/usr/lib/python2.7/site-packages/TRML2PDF-1.0-py2.7.egg

this egg file in fact is a zip file that does contain trml2pdf/trml2pdf.py

On the other hand, when using F18 or F19 as target the review tool seems to run
to completion:
   fedora-review -b 821455 -m fedora-18-x86_64
   fedora-review -b 821455 -m fedora-19-x86_64
both run fine.

It seems to me the default behaviour of easy_install has changed in rawhide. In
F18 and F19 the egg file is automatically extracted/unzipped, but in rawhide
this no longer happens. Maybe adding the easy_install commandline option
--always-unzip could help here?

Anyway, it is not really clear to me why you wish to use the easy_install tool
to do the build and installation. Just plainly using the setup script seems
easier to me (and probably would not have this issue).

Just adding
   %{__python} setup.py build
to the %build section, and
   %{__python} setup.py install --skip-build --root %{buildroot}
to the %install section of the spec file should do the trick.

Apart from this, the review tool complains that the spec file you provide
differs from the spec file included in the srpm. Please fix this.

The rpmlint results reported by the review tool are:
Rpmlint
-------
Checking: python-trml2pdf12-1.2-5.fc19.noarch.rpm
          python-trml2pdf12-1.2-5.fc19.src.rpm
python-trml2pdf12.noarch: W: spelling-error %description -l en_US compat ->
compact, combat, cowpat
python-trml2pdf12.noarch: E: incorrect-fsf-address
/usr/share/doc/python-trml2pdf12-1.2/LICENSE.txt
python-trml2pdf12.src: W: spelling-error %description -l en_US compat ->
compact, combat, cowpat
2 packages and 0 specfiles checked; 1 errors, 2 warnings.

so these are still the same.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]