https://bugzilla.redhat.com/show_bug.cgi?id=1015867 --- Comment #5 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi Mosaab I would like have this package in Fedora repositories, would be nice for end users to have a gui for conky. - naming of the spec is wrong, the name must be the same of the upstream, just conky-manager - i think that url should be http://teejeetech.blogspot.in/p/conky-manager.html - licenses tag is wrong,licenses should be GPLv... not GPL... also the package is GPLv3 according to the COPYING file but have some files under GPLv2+, i think that package should be just GPLv3+ GPL (v2 or later) ----------------- /home/echevemaster/1015867-conky-manager-1.2.0.1-2/upstream-unpacked/Source0/conky-manager-1.2.0.1/src/Main.vala /home/echevemaster/1015867-conky-manager-1.2.0.1-2/upstream-unpacked/Source0/conky-manager-1.2.0.1/src/MainWindow.vala /home/echevemaster/1015867-conky-manager-1.2.0.1-2/upstream-unpacked/Source0/conky-manager-1.2.0.1/src/Utility.vala one question, themepacks should be compressed for run? rpmls conky-manager-1.2.0.1-2.fc20.x86_64.rpm -rwxr-xr-x /usr/bin/conky-manager -rw-r--r-- /usr/share/applications/conky-manager.desktop -rw-r--r-- /usr/share/conky-manager/images/conky-manager.png -rw-r--r-- /usr/share/conky-manager/images/conky-manager.xcf -rw-r--r-- /usr/share/conky-manager/themepacks/default-themes-1.1.cmtp.7z -rw-r--r-- /usr/share/conky-manager/themepacks/default-themes-1.2.cmtp.7z drwxr-xr-x /usr/share/doc/conky-manager -rw-r--r-- /usr/share/doc/conky-manager/AUTHORS -rw-r--r-- /usr/share/doc/conky-manager/COPYING -rw-r--r-- /usr/share/doc/conky-manager/README -rw-r--r-- /usr/share/doc/conky-manager/TODO -rwxr-xr-x /usr/share/pixmaps/conky-manager.png - it's expected that BR are devel packages, in this case vala-devel is the correct - please stop the use of pkconfig in BR, retrieving of dependencies is more slow using this way. do you want to know the name of the packages? use repoquery repoquery -qf 'pkgconfig(glib-2.0)' glib2-devel-0:2.36.3-2.fc19.i686 glib2-devel-0:2.36.3-3.fc19.i686 glib2-devel-0:2.36.3-2.fc19.x86_64 glib2-devel-0:2.36.3-3.fc19.x86_64 repoquery -qf 'pkgconfig(gtk+-3.0)' gtk3-devel-0:3.8.4-1.fc19.i686 gtk3-devel-0:3.8.4-1.fc19.x86_64 gtk3-devel-0:3.8.2-2.fc19.i686 gtk3-devel-0:3.8.2-2.fc19.x86_64 repoquery -qf 'pkgconfig(gee-1.0)' libgee06-devel-0:0.6.8-1.fc19.x86_64 libgee06-devel-0:0.6.8-1.fc19.i686 - Please give a name more explicit to the patch, conky0.patch doesn't says anything about with it does the patch - there are a typo in the description Concky manger improves conky effects to be beautiful and simple. also there are a better description in launchpad "A simple GUI for managing Conky config files. Options for changing themes and running Conky at startup." if the tarball meets with the way %{name}-%{version} isn't needed -n option %setup -qn %{name}-%{version} - Don't needed wilcards (*.*) in this case for listing the files Regards -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review