https://bugzilla.redhat.com/show_bug.cgi?id=1016370 --- Comment #4 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- For -2: * About excluding /usr/bin/ruby dependency - Well, I don't oppose to this (i.e. not a blocker), however I don't think adding this line makes so much sense... We don't explicitly exclude shebang dependency on other packages even if they don't contain the explicit dependency which provides such interpreter (such as bash). * Removing mini_shoulda dependency - Well, actually the following line is added: ------------------------------------------------------ 66 # We must remove mini_shoulda in the installed gemspec, too. 67 sed -e '\|mini_shoulda|d' -i .%{gem_spec} ------------------------------------------------------ However, instead it is better that you fix the following line: ------------------------------------------------------ 55 sed -e '\|mini_shoulda"|d' -i %{gem_name}.gemspec ------------------------------------------------------ Note: - Check the actually generated %{gem_name}.gemspec, which does not match 'mini_shoulda"' (note that one unknown double quotation mark is included in the regex) Otherwise okay. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review