Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-LockFile-Simple - Simple file locking scheme https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232625 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-03-21 01:27 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url acf9fd6f965789a42fa5314a4be0189d LockFile-Simple-0.2.5.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/basic.....ok t/simple....ok t/user......ok All tests successful. Files=3, Tests=13, 0 wallclock secs ( 0.06 cusr + 0.02 csys = 0.08 CPU) + Provides: perl(LockFile::Lock) perl(LockFile::Lock::Simple) perl(LockFile::Manager) perl(LockFile::Simple) = 0.205 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review