https://bugzilla.redhat.com/show_bug.cgi?id=1016370 Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- Some notes: * mini_shoulda dependency - Installed %gem_spec still contains mini_shoulda dependency. Currently it is for development_dependency so no runtime dependency is added, but anyway I think this is against your intention. * Executing tests - Actually no tests are executed. Please check %check section. ------------------------------------------------------- Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.IQdVQm + umask 022 + cd /builddir/build/BUILD + cd capillary-1.0.3 + pushd ./usr/share/gems/gems/capillary-1.0.3 ~/build/BUILD/capillary-1.0.3/usr/share/gems/gems/capillary-1.0.3 ~/build/BUILD/capillary-1.0.3 + testrb -Ilib test/capillary/commit_test.rb test/capillary/log_parser_test.rb test/capillary/ref_collection_test.rb test/capillary/commit_test.rb: cannot load such file -- test_helper test/capillary/log_parser_test.rb: cannot load such file -- test_helper test/capillary/ref_collection_test.rb: cannot load such file -- test_helper Run options: -Ilib # Running tests: Finished tests in 0.002931s, 0.0000 tests/s, 0.0000 assertions/s. 0 tests, 0 assertions, 0 failures, 0 errors, 0 skips ^^^^^^^^ ruby -v: ruby 2.0.0p247 (2013-06-27 revision 41674) [i386-linux] ~/build/BUILD/capillary-1.0.3 + popd + exit 0 ------------------------------------------------------- * Documentation - I recommend "README" to be put in main package, because the file "README" is actually the upstream want user to read it. - Please consider if "Gemfile{,.lock}" "Rakefile" really needs to be included in binary rpm. - Especially "Rakefile" is like makefiles in autotool- generated tarballs, which we usually don't include in binary rpm. - tests scripts are usually not needed in binary rpm: https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites See "Do not ship tests" -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review