[Bug 806117] Review Request: python-oplop - Generate account passwords based on account nicknames

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=806117



--- Comment #19 from Eduardo Echeverria <echevemaster@xxxxxxxxx> ---
I agree with @cicku

As I said above the package don't have support for python =< 2.4; so do you
must remove the epel5 stuff

- %clean is not needed
- BuildRoot is not needed

and remove these lines:

%if 0%{?rhel} && 0%{?rhel} <= 5
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif

btw, I don't know why always the pipy tarballs never contains the boilerplate
of the licenses (thing that annoying me), but in the package's github we can
see the license , please add of local way or build all the package directly
from the github's source =>
https://github.com/brettcannon/oplop/blob/master/LICENSE


if you decide build from github's sources please handle the url following the
guidelines 

https://fedoraproject.org/wiki/Packaging:SourceURL#Github

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]