[Bug 919703] Review Request: libgap - libGAP -- a C library version of the GAP kernel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=919703



--- Comment #16 from Jerry James <loganjerry@xxxxxxxxx> ---
It's trying to print the value of the ebp register, which only exists on x86. 
I don't see why that is even necessary.  It doesn't seem to be checked or used
in any way.  Perhaps print_stack_start() could be made conditional on x86
platforms, something like this:

#if defined(__i686__) || defined(__x86_64__)
void print_stack_start()
{
...
}
#else
void print stack_start()
{
  int i;
  printf("&i = %p\n", &i);
  printf("frame addres = %p\n", __builtin_frame_address(0));
}
#endif

I will comment more on the current spec file in a couple of hours.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]