https://bugzilla.redhat.com/show_bug.cgi?id=1016221 --- Comment #2 from Christopher Meng <cickumqt@xxxxxxxxx> --- CCing because of interests. Marking DUP of before one. Thoughts: 1. I can see license clarification at the top of the spec, I don't think we need that. 2. I don't know if you can remove : ################################################################################ in the spec? As it's looking funny since this spec is not difficult for reading like kernel. 3. Group: System Environment/Daemons Since Fedora doesn't need it as MUST, you can remove that or change to the correct one, I don't think it's a daemon. 4. Remove some tags cause they are obsoleted after Fedora 10: BuildRoot: -- rm -rf $RPM_BUILD_ROOT in %install -- Whole %clean section -- %defattr(-,root,root,-) 5. I can see old style: Requires: %{name} = 0:%{version}-%{release} Please remove epoch in the version requires: Requires: %{name} = %{version}-%{release} I think we should add isa tag as: Requires: %{name}%{?_isa} = %{version}-%{release} http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_and_.25.7B_isa.7D 6. Sort BR like in alphabetical order: BuildRequires: expect BuildRequires: libltdl-devel BuildRequires: gdbm-devel BuildRequires: openldap-devel BuildRequires: pam-devel BuildRequires: mysql-devel BuildRequires: postgresql-devel BuildRequires: sqlite3-devel 7. Why this? MAKEFLAGS= make -j 1 install DESTDIR=$RPM_BUILD_ROOT MAKEFLAGS= make -j 1 install-configure DESTDIR=$RPM_BUILD_ROOT Why can't use parallel make? http://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make 8. All install should be with -p option to preserve the timestamps. http://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps 9. The authenumerate.8 page comes from Debian, but do you think it's helpful? http://sources.debian.net/data/main/c/courier-authlib/0.63.0-6/debian/authenumerate.pod (pod2man convert is needed if you really want to build from 'source') 10. %changelog: -New initial RPM release heavily based on source spec file and the below changes We can see others keeping a good style, so you can leave a space after "-" 11. Other distros have -authdaemon subpackage, would you like keep the same style with them? 12. configure should be with --disable-static 13. mkdir -p $RPM_BUILD_ROOT%{_datadir} install -m 555 %{name}.sysvinit $RPM_BUILD_ROOT%{_datadir} First, you should use %doc to mark it as doc, avoid installing them directly. Second, do we need this under systemd? Any substitution avail? -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review