https://bugzilla.redhat.com/show_bug.cgi?id=1015867 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@xxxxxxxxx --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. Summary: Simple tool for managing conky scripts. Never leave a dot "." at the end of the summary tag. 2. Ask upstream to add download support on https://launchpad.net/conky-manager/ so it will be easier to retrieve sources. To me the source is located at https://launchpad.net/~teejee2008/+archive/ppa/+files/conky-manager_1.2.0.1.tar.gz 3. Remove explicit requires Requires: conky, lm_sensors, hddtemp, p7zip, p7zip-plugins, libgee06 e.g libgee06 can be automatically detected during installation. 4. %{_datadir}/applications/conky-manager.desktop You should use desktop-file-install to install/validate it. http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage 5. make missing smp flags. http://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make 6. It's nonsense to write (stable version) in description. 7. Don't leave blank lines in %changelog. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review