https://bugzilla.redhat.com/show_bug.cgi?id=1014544 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@xxxxxxxxxx --- Comment #2 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- Some remarks: There are quite a few issues with this submission: 1. You (Mosaab Alzoubi) are pointing to a package in SUSE's OBS, which appears to have been authored by somebody named "Muhammad Shaban". Could you elaborate this situation? 2. The spec files needs further work to comply with the Fedora Packaging Guidelines. Please make yourself familiar with the Fedora Packaging Guidelines. Just to mention some issues: - Source: %{name}-%{version}.tar.bz2 Source/Source0 should be an URL pointing to an upstream hosting the tarball. - URL-Tag is missing Where can upstream be found? - Requires: perl cpio rpm dpkg debhelper gcc rpm-build Please check this. These Requires: seem questionable to me. E.g. I cannot spot any reference to gcc inside of this package. - Obsoletes: alien alien-almasa Provides: alien alien-almasa IIRC, alien-almasa has never been part of Fedora => there isn't any reason to Obsolete/Provide: alien-almasa in Fedora. AFAIS, this package does not conflict with alien and can coexist with alien. => there isn't any reason to Obsolete/Provide: alien - In Fedora, %description is supposed to be in English. Mixing other languages and/or scripts into %description is not allowed. If you want to keep/add an Arabic description, move the Arab description into a separate "%description -l ar" section. [N.B.: Chances to getting this package into Fedora a bigger, if you entirel remove the Arab section, because most Fedora packagers don't understand/read Arab and therefore will not be able to check this package for "legibility" and will not be able to approve this package. c.f. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Spec_Legibility.] - I understand, this spec file's author isn't a native English speaker and likely has limited knowledge of the English language, however this package's %description is phrased in a way, I feel, it should be reworked. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review