https://bugzilla.redhat.com/show_bug.cgi?id=1014353 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxxxxx --- Comment #8 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- Review submitted 2013-10-01 15:19:16 Review approved 2013-10-01 16:42:10 This don't let other time to have a minimal look at it :-( Obviously : [!]: Package complies to the Packaging Guidelines Please read: http://fedoraproject.org/wiki/Packaging:PHP Requires: php >= 5.1.2 => A PHP library must not have an explicit Requires on php or httpd.. >From phpcompatinfo report should be Requires: php(language) >= 5.1.2 (but this one have no interest) Requires: php-curl Requires: php-pcre %{_datadir}/lightopenid => Non-PEAR PHP software which provides shared libraries should put its PHP source files for such shared libraries in a subfolder of /usr/share/php [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. So ? no link to upstream request or bug report ? [!]: Packages should try to preserve timestamps of original installed files. So ? Ok, the package have been fixed, but this is not traced here. > Otherwise, this package is APPROVED Really ? Reviews are not a speed competition ! Please fix the package. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review