https://bugzilla.redhat.com/show_bug.cgi?id=1014336 --- Comment #5 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- First, I'm not really satisfied with the behavior of your download links. Reviewers should be able to simply right-click on a link to save its target. Dropbox allows this actually, but it seems you've copied the file link from your browser's address bar. This doesn't point to the file itself, rather to a website where I have to click on a button to download it. To avoid this, open your Dropbox in the browser, select the desired file and click on "Copy public link" (sorry, could be some different, I'm using Dropbox in German). Even the available file manager plugins for Nautilus, Dolphin etc. should have such an option. Scratch build:: http://koji.fedoraproject.org/koji/taskinfo?taskID=6017702 $ rpmlint -i -v * python-halite.src: I: checking python-halite.src: W: spelling-error %description -l en_US pre -> per, ore, pee The value of this tag appears to be misspelled. Please double-check. python-halite.src: W: spelling-error %description -l en_US devel -> delve, devil, revel The value of this tag appears to be misspelled. Please double-check. python-halite.src: I: checking-url https://github.com/saltstack/halite/ (timeout 10 seconds) python-halite.src:51: E: use-of-RPM_SOURCE_DIR You use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to use a directory for building, use $RPM_BUILD_ROOT instead. python-halite.src:23: W: mixed-use-of-spaces-and-tabs (spaces: line 23, tab: line 11) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. python-halite.src: I: checking-url https://github.com/saltstack/halite/blob/v${version}/LICENSE (timeout 10 seconds) python-halite.src: W: invalid-url Source1: https://github.com/saltstack/halite/blob/v${version}/LICENSE HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL. python-halite.src: I: checking-url https://pypi.python.org/packages/source/h/halite/halite-0.1.01.tar.gz (timeout 10 seconds) python-halite.noarch: I: checking python-halite.noarch: W: spelling-error %description -l en_US pre -> per, ore, pee The value of this tag appears to be misspelled. Please double-check. python-halite.noarch: W: spelling-error %description -l en_US devel -> delve, devil, revel The value of this tag appears to be misspelled. Please double-check. python-halite.noarch: I: checking-url https://github.com/saltstack/halite/ (timeout 10 seconds) python-halite.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/halite/bottle.py 0644L /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. python-halite.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/halite/server_bottle.py 0644L /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. python-halite.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/halite/genindex.py 0644L /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. python-halite.spec:51: E: use-of-RPM_SOURCE_DIR You use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to use a directory for building, use $RPM_BUILD_ROOT instead. python-halite.spec:23: W: mixed-use-of-spaces-and-tabs (spaces: line 23, tab: line 11) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. python-halite.spec: I: checking-url https://github.com/saltstack/halite/blob/v${version}/LICENSE (timeout 10 seconds) python-halite.spec: W: invalid-url Source1: https://github.com/saltstack/halite/blob/v${version}/LICENSE HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL. python-halite.spec: I: checking-url https://pypi.python.org/packages/source/h/halite/halite-0.1.01.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 5 errors, 8 warnings. Some of the issues need to be fixed or investigated: I don't know why $RPM_SOURCE_DIR is not allowed, but I assume there are good reasons for. It is unusual at least, never seen this before in a spec file. Just use %RPM_BUILD_ROOT instead. There are some scripts which have a shebang, but are not executable. Scripts in %{python_sitelib} don't need a shebang. Please remove them. Don't mix spaces and tabs. I recommend spaces, because this way the spec file looks the same in any text editor, independent from the configured tab width. The download location for the license file is not available, please investigate. %if 0%{?fedora} >= 8 BuildRequires: python-setuptools-devel %else BuildRequires: python-setuptools %endif First, we don't need any definitions which refer to Fedora 7 and earlier. Well, you could apply this condition to EPEL 5 which is based on FC6. Besides that, python-setuptools-devel is virtually provided by python-setuptools. As far as I can see, this definition can be omitted. Consider to use %global instead of %define. See https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25global_preferred_over_.25define for more information. Last but not least, please get rid of the spec parts which are only needed for EPEl 5 once your package will be imported into EPEL >= 6 and Fedora: * BuildRoot definition * The header which defines python_sitelib * Initial cleaning of buildroot in %install * The %clean section * %defattr line in %files -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=utl2ZuR3ZE&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review