https://bugzilla.redhat.com/show_bug.cgi?id=1012681 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org | --- Comment #3 from Christopher Meng <cickumqt@xxxxxxxxx> --- Hmmm... You can drop support for EL5 as if it doesn't work well with 1.25 version. So if you don't need to support EL5(I didn't mean EL6), remove: BuildRoot tag; rm -rf %{buildroot} in %install section; Whole %clean section; %defattr(-,root,root,-) in %files section. ---------- Source: %{name}-%{version}.tar.gz Well, I think you should know pypi, if you think handling this is not perfect, release it to pypi. ---------- BuildRequires: python-devel is deprecated and should use BuildRequires: python2-devel now. ---------- If you ONLY want to support Fedora ;) , please note that you should also(include above python-devel change): %{__python} --> %{__python2} %{python_sitearch} --> %{python2_sitearch} -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zPi2YsJGxK&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review