https://bugzilla.redhat.com/show_bug.cgi?id=1012392 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@xxxxxxxxx --- Comment #4 from Christopher Meng <cickumqt@xxxxxxxxx> --- CCing cuz I've packaged it. Informal review: 1. Summary: nanomsg is a socket library that provides several common communication patterns. Bad. Suggestion: Summary: A socket library which provides several common communication patterns 2. Remove BuildRoot tag. 3. It's nonsense to Requires: pkgconfig in -devel subpackage. 4. Why do we need static libs? If you don't recommend using it, you can drop it, or there really have people like static linking? 5. devel subpackage has: Requires: %{name} = %{version}-%{release} Should use: Requires: %{name}%{?_isa} = %{version}-%{release} 6. Put %check after %install 7. Remove rm -rf $RPM_BUILD_ROOT in %install 8. Why rm -f $RPM_BUILD_ROOT%{_infodir}/dir ? 9. Remove %clean section. 10. Remove %defattr(-,root,root,-) 11. Use %doc to define which are docs. 12. %dir %{_includedir}/%{name} %{_includedir}/%{name}/*.h Just %{_includedir}/%{name} is the best. 13. I don't think you need to say "It is licensed under MIT/X11 license." in %description, Fedora only allows OPEN SOURCE projects. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UygOMn4Spi&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review