https://bugzilla.redhat.com/show_bug.cgi?id=1010857 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mario.blaettermann@xxxxxxxx | |m Assignee|nobody@xxxxxxxxxxxxxxxxx |mario.blaettermann@xxxxxxxx | |m Flags| |fedora-review+ --- Comment #1 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5977994 $ rpmlint -i -v *keyrings-filesystem.noarch: I: checking keyrings-filesystem.noarch: W: no-url-tag The URL tag is missing. keyrings-filesystem.noarch: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. keyrings-filesystem.src: I: checking keyrings-filesystem.src: W: no-url-tag The URL tag is missing. 2 packages and 1 specfiles checked; 0 errors, 3 warnings. Of course we have no URL tag because there are no sources and no upstram project, so we also don't have docs. I omit here the usual checklist for reviews due to the nature of this package. Just a few comments: * Spec file is legible. * Licensing under Public Domain is approved by Fedora. * rpm is added as a runtime requirement to own the folder /etc/rpm/. * Macros are used consistently. * Package builds properly in Mock (see the Koji build) * Filenames are utf-8. ---------------- PACKAGE APPROVED ---------------- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oW2lbu7h2J&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review