https://bugzilla.redhat.com/show_bug.cgi?id=1011501 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@xxxxxxxxx --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- No need to: Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig --- Requires: %{name} = %{version}-%{release} Missing ?isa macro --- Please use github tag: https://github.com/hawaii-desktop/qt-accountsservice-addon/releases And rewrite the Source0 tag. --- Please add a dot at the end of every %description. And, %description(devel): Devel for Qt Account Service Addon is not good. Please change. (Devel is what when you see a -devel package? ;)) --- Remove rm -rf $RPM_BUILD_ROOT --- Remove %defattr(-,root,root,-) --- Keep docs in one line if you want. --- %{_includedir}/qt5/QtAccountsService/* Unowned %{_includedir}/qt5/QtAccountsService itself --- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YNMSyiie9E&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review