https://bugzilla.redhat.com/show_bug.cgi?id=1007972 Lubomir Rintel <lkundrak@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lkundrak@xxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |lkundrak@xxxxx Flags| |fedora-review? --- Comment #1 from Lubomir Rintel <lkundrak@xxxxx> --- Hi Christopher! The package looks mostly fine to me. Just a few notes before an official review: 1.) There's no need for an build directory. Just running cmake for "." and make install without cd-ing would do and be more consistent with other cmake packages. 2.) My quick overview of the licensing suggested it should be "LGPLv3+ and GPLv2 and Public Domain". I could be wrong as well; but would you mind explaining why do you think it's GPLv2? Also, do you plan on progressin with rest of Hawaii stack? I've done some packaging already [1], it does not readily work yet though. If yes, is there a way we could join forces? :) I've imported qt5-qtwayland and qt5-qtquickcomponents today by the way, if you have packages depending on those. [1] https://fedoraproject.org/wiki/User:Lkundrak/Hawaii_Desktop Have a nice day! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Hgu5L3vUph&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review