[Bug 1010613] Review Request: ck - Concurrency Kit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1010613

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx



--- Comment #1 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
Some remarks:

- Package contains a testsuite. Please add
%check
make check

- Package fails to build on arm:
...
+ CFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches 
-march=armv7-a -mfpu=vfpv3-d16  -mfloat-abi=hard'
+ ./configure --libdir=/usr/lib --includedir=/usr/include/ck
--mandir=/usr/share/man --prefix=/usr
Detecting operating system.......success [linux]
Detecting machine architecture...failed  [unsupported]
[http://koji.fedoraproject.org/koji/taskinfo?taskID=5966306]


- The contents of build/ck.build.<arch> is quite questionable.
1) They try to override cpp defines from the name space reserved to the system
(compiler/libc).
So far, though this isn't correct, the impact of this happens to be harmless.

2) ck.build.i386 sets -msse -msse2.
This is not allowed in Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vi0GZMgtID&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]