https://bugzilla.redhat.com/show_bug.cgi?id=1010000 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@xxxxxxxxxx --- Comment #4 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- Not a formal review, just some remarks based on brief visual inspection of your spec: - You should not BR: these: BuildRequires: perl-DB_File BuildRequires: perl-File-DesktopEntry BuildRequires: perl-Parse-DebControl BuildRequires: perl-Pod-Checker but BR: the perl modules which are being used (i.e. use BR: perl(...)) - BR: dpkg-perl I am haven't looked into details, but I'd assume this package doesn't actually require "dpkg-perl" but some perl modules provided by dpkg-perl. I.e. the same consideration as above also applies here. - A typo ("builroot", note the missing "d"): rm -rf %{builroot}%{_datadir}/doc -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Q307ATHVSC&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review