[Bug 1009967] Review Request: golang-googlecode-net - Supplementary Go networking libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1009967



--- Comment #2 from Matthew Miller <mattdm@xxxxxxxxxx> ---
I know you're still working on this, but as it stands 

    
/usr/lib64/golang/src/pkg/code.google.com/p/go.net/html/testdata/webkit/scripted
     /usr/lib64/golang/src/pkg/code.google.com/p/go.net/html/testdata/webkit
     /usr/lib64/golang/src/pkg/code.google.com/p/go.net/html/testdata
     /usr/lib64/golang/pkg/linux_amd64/code.google.com/p/go.net/html
     /usr/lib64/golang/src/pkg/code.google.com/p/go.net/html/atom

are unowned directories.

-------------------------------------------------------------------

Also, in the build loop it looks like you want to exclude all the dirs that
match 'testdata', right? You can do that with


   "$dir" =~ "testdata" 

(or a more specific regular expression if you're worried that that is too
broad.)

-------------------------------------------------------------------

Also, the webkit readme is stomping on the main README in the docs. I suggest
renaming it to README-webkit (in the %prep section, I suppose).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZGMoq7e9uz&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]