[Bug 1009153] Review Request: javolution - Real-time Java library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1009153



--- Comment #5 from gil cattaneo <puntogil@xxxxxxxxx> ---
(In reply to gil cattaneo from comment #3)
> please, remove from spec file these 
> 
> BuildRequires: javapackages-tools
> BuildRequires: maven
> BuildRequires: maven-compiler-plugin
> BuildRequires: maven-install-plugin
> BuildRequires: maven-javadoc-plugin
> BuildRequires: maven-source-plugin
> BuildRequires: maven-surefire-plugin
> 
> all Group fiels        - no more required
> all Requires           - added by java package tools (XMvn)
> 
> fix unowned directory
> add %dir %{_javadir}/%{name}
> in main package
> 
> if possible use pom macros
> e.g.
> %pom_remove_plugin javolution:colapi
> %pom_xpath_remove "pom:project/pom:build/pom:extensions[pom:groupId =
> 'org.jvnet.wagon-svn' ]"
> or
> %pom_xpath_remove "pom:project/pom:build/pom:extensions"
> 
> fix license field
> License:       BSD and Public domain

should be correct as this last one
License:       BSD
> 
> these are under  Public domain license
> 
because you must remove all bundled libraries
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
> already available in xml-commons-apis package or in OpenJDK rt.jar

> /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/
> src/main/java/org/xml/sax/AttributeList.java
> /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/
> src/main/java/org/xml/sax/DTDHandler.java
> /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/
> src/main/java/org/xml/sax/DocumentHandler.java
> /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/
> src/main/java/org/xml/sax/EntityResolver.java
> /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/
> src/main/java/org/xml/sax/ErrorHandler.java
> /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/
> src/main/java/org/xml/sax/HandlerBase.java
> /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/
> src/main/java/org/xml/sax/InputSource.java
> /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/
> src/main/java/org/xml/sax/Locator.java
> /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/
> src/main/java/org/xml/sax/Parser.java
> /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/
> src/main/java/org/xml/sax/SAXException.java
> /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/
> src/main/java/org/xml/sax/SAXParseException.java
>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TrNIavNhgP&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]