[Bug 1009153] Review Request: javolution - Real-time Java library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1009153

gil cattaneo <puntogil@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |puntogil@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #3 from gil cattaneo <puntogil@xxxxxxxxx> ---
please, remove from spec file these 

BuildRequires: javapackages-tools
BuildRequires: maven
BuildRequires: maven-compiler-plugin
BuildRequires: maven-install-plugin
BuildRequires: maven-javadoc-plugin
BuildRequires: maven-source-plugin
BuildRequires: maven-surefire-plugin

all Group fiels        - no more required
all Requires           - added by java package tools (XMvn)

fix unowned directory
add %dir %{_javadir}/%{name}
in main package

if possible use pom macros
e.g.
%pom_remove_plugin javolution:colapi
%pom_xpath_remove "pom:project/pom:build/pom:extensions[pom:groupId =
'org.jvnet.wagon-svn' ]"
or
%pom_xpath_remove "pom:project/pom:build/pom:extensions"

fix license field
License:       BSD and Public domain

these are under  Public domain license

Public domain
-------------
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/AttributeList.java
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/DTDHandler.java
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/DocumentHandler.java
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/EntityResolver.java
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/ErrorHandler.java
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/HandlerBase.java
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/InputSource.java
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/Locator.java
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/Parser.java
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/SAXException.java
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/SAXParseException.java


remove bundled library
already available in xml-commons-apis package or in OpenJDK rt.jar

/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/Attributes.java
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/ContentHandler.java
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/SAXNotRecognizedException.java
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/SAXNotSupportedException.java
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/XMLFilter.java
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/XMLReader.java

fix wrong-file-end-of-line-encoding /usr/share/doc/javolution/LICENSE.txt
e.g.
sed -i 's/\r//' LICENSE.txt

not approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Iqhx9D5NOp&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]