[Bug 1008816] Review Request: libkkc-data - Language model data for libkkc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1008816

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|package-review@lists.fedora |
                   |project.org                 |
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ package build successfully in mock 

- rpmlint on rpms gave
libkkc-data.x86_64: E: no-binary
libkkc-data.x86_64: W: only-non-binary-in-usr-lib
libkkc-data.x86_64: W: no-documentation
libkkc-data-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 2 errors, 2 warnings.


+ Source validated to upstream as (sha256sum)
srpm tarball     :
9e678755a030043da68e37a4049aa296c296869ff1fb9e6c70026b2541595b99
upstream tarball :
9e678755a030043da68e37a4049aa296c296869ff1fb9e6c70026b2541595b99

+ license is valid and included in COPYING

Suggestions:
1) Add %doc COPYING
also good if you are upstream then add some contents to file README, ChangeLog
and add them in %doc

2) you may want to disable -debuginfo package by adding at the top of spec
# This is just data package that installs data files only
%global debug_package %{nil}


I see this is still valid https://bugzilla.redhat.com/show_bug.cgi?id=906248#c8
so, not to worry for rpmlint warning only-non-binary-in-usr-lib

When you import this package you first need to update libkkc.spec by removing
libkkc-data subpackage and then build this package.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EOWXwTo8Fw&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]