[Bug 1008799] Review Request: python-beanstalkc - A simple beanstalkd client library for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1008799

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
+ is ok
- is needs attention

Review:

+ Package builds find in mock rawhide

- rpmlint on rpms gave
python-beanstalkc.src: W: spelling-error Summary(en_US) beanstalkd ->
beanstalks, beanstalk, beanstalk d
python-beanstalkc.src: W: spelling-error %description -l en_US beanstalkd ->
beanstalks, beanstalk, beanstalk d
python-beanstalkc.src: W: spelling-error %description -l en_US workqueue ->
work queue, work-queue, workhouse
python-beanstalkc.noarch: W: spelling-error Summary(en_US) beanstalkd ->
beanstalks, beanstalk, beanstalk d
python-beanstalkc.noarch: W: spelling-error %description -l en_US beanstalkd ->
beanstalks, beanstalk, beanstalk d
python-beanstalkc.noarch: W: spelling-error %description -l en_US workqueue ->
work queue, work-queue, workhouse
python-beanstalkc.noarch: W: no-documentation
python-beanstalkc.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/beanstalkc.py 0644L /usr/bin/env
2 packages and 0 specfiles checked; 1 errors, 7 warnings.

==> Fix non-executable-script error by adding at the end of %prep section
sed -i -e '/^#!\//, 1d' beanstalkc.py

+ Source verified with upstream as (sha256sum)
srpm tarball     :
45c3915ed876f80712fcafadee0feaaf0628e5c297e33aaea7f7b229deb80467
upstream tarball :
45c3915ed876f80712fcafadee0feaaf0628e5c297e33aaea7f7b229deb80467

+ License is valid and included in actual source file header

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1TDG1CdPuY&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]