Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xmlrpc3 - Java XML-RPC implementation https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233004 ------- Additional Comments From overholt@xxxxxxxxxx 2007-03-20 11:56 EST ------- Updated SRPM and spec: http://www.overholt.ca/fedora/xmlrpc3.spec http://www.overholt.ca/fedora/xmlrpc3-3.0-1jpp.1.src.rpm (In reply to comment #2) > ? package is named appropriately > > - I guess the major version is included in the name because 3 > breaks compatibility with the version 2 series? Yes. > X rpmlint on <this package>.srpm gives no output > > - change the non-standard groups in the subpackages Groups aren't a blocker, but I've fixed them anyway. > X specfile is legible > > - remove the unneeded Epoch line > > - fix the Buildroot tag Done and done. > X no %files duplicates > > - LICENSE.txt duplicates across subpackages I thought sub-packages should all contain it, but I've removed it from all but -common. > X file permissions okay; %defattrs present > > - '-', not explicit permissions Okay. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review