https://bugzilla.redhat.com/show_bug.cgi?id=1007577 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@xxxxxxxxxx --- Comment #2 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- There are several details in the spec, I do not understand: a) Why this: ... # the testsuite is a good example for using this lib cp -a tests examples rm -rf examples/._* \ examples/Makefile* ... To make these files available as examples, before building starts cluttering the "tests" directory with intermediate files (*.o etc.)? b) Why are you running autoreconf? I do not see any reason why this spec needs to run autoreconf. The tarball seem to contain broken timestamps, but these can be overcome in less intrusive ways, which do not expose the sources to the risks of autoreconf (Autoreconf is very dangerous, esp. in cases sources contain fortran code). c) What are these "._*" files to be found all over the place? I think, all of them are not used and probably can be removed in %prep. d) arprec-config contains arch-specific settings => arprec-common-devel can not be noarched My advise would be to implement a new arprec-config based on pkg-config which is call-compatible to the original arprec-config. e) IMO, the packaging is unnecessarily fine grained. That said, I do not see much reasons for arprec-common-devel, arprec-doc, arprec-tools-common and would advise against this kind of packaging. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s8juXd7fFq&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review