https://bugzilla.redhat.com/show_bug.cgi?id=998469 Ken Dreyer <ktdreyer@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ktdreyer@xxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |ktdreyer@xxxxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> --- Hi Miroslav, I can take this package. In the latest Ruby guidelines, %prep is supposed to contain "gem unpack" and "gem spec", %build is supposed to contain "gem build", etc. https://fedoraproject.org/wiki/Packaging:Ruby On the Ruby Packaging Guidelines page, the example is clear about this, and gem2rpm's template also follows the unpack -> spec -> re-pack pattern. My understanding was that point of adding this in the Fedora 19 Ruby Packaging guidelines was that we would now be building the gem "from source". Would you mind altering your package to fit the conventions on the Ruby Packaging Guidelines page? You could then delete .yardoc during %prep, which seems more natural to me. If you strongly disagree with this, why not propose a change to the packaging guidelines to fit your style? Also, can please you use the %gem_install macro, since that is one of the things that fedora-review checks? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HdnS2Qovkl&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review