https://bugzilla.redhat.com/show_bug.cgi?id=1003768 --- Comment #1 from Sandro Mani <manisandro@xxxxxxxxx> --- - The URL for the source is missing. Please see [1] for the guidelines on github urls - According to the ChangeLog, the version is 0.1.1 - For post-release snapshots, follow the guidelines here [2], i.e. append .git%{shortcommit} to Release - Detail: you could replace "make install DESTDIR=%{buildroot}" by "%make_install" (see rpm -E '%make_install') Rest looks good! [1] http://fedoraproject.org/wiki/Packaging:SourceURL#Github [2] http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LIKvuRnzFU&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review