[Bug 1006860] Review Request: libnatpmp - Library of The NAT Port Mapping Protocol (NAT-PMP)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1006860

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|package-review@lists.fedora |
                   |project.org                 |
                 CC|                            |rc040203@xxxxxxxxxx



--- Comment #1 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
Package fails to build in mock:
...
/usr/bin/ld: natpmp.o: relocation R_X86_64_32S against `.rodata' can not be
used when making a shared object; recompile with -fPIC
natpmp.o: could not read symbols: Bad value
collect2: error: ld returned 1 exit status
make: *** [libnatpmp.so] Error 1
...

The cause seems obvious:

By invoking 'make CFLAGS="%{optflags}", you are overriding the CFLAGS within
the Makefile, causing the package to loose the CFLAGS given in the Makefile.

Depending on what you intend, you either could opt to
- propagate %optflags into the Makefile, e.g. something similar to
  sed -i "s|CFLAGS =.*$|CFLAGS = %{optflags}|" Makefile
or
- explicitly append all desired CFLAGS contained in the Makefile to the CFLAGS
in the make call e.g. something similar to
  make CFLAGS="%{optflags} -fPIC -DENABLE_STRNATPMPERR"
or <something else>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MwbaAN82hx&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]